Bug 1064

Summary:	Change XLEN-ification
Product:	Libre-SOC's first SoC	Reporter:	Jacob Lifshay <programmerjake>
Component:	Specification	Assignee:	Jacob Lifshay <programmerjake>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	libre-soc-isa, programmerjake
Priority:	---
Version:	unspecified
Hardware:	PC
OS:	Linux
See Also:	https://bugs.libre-soc.org/show_bug.cgi?id=1061
NLnet milestone:	NLnet.2022-08-107.ongoing	total budget (EUR) for completion of task and all subtasks:	1000
budget (EUR) for this task, excluding subtasks' budget:	1000	parent task for budget allocation:	1027
child tasks for budget allocation:		The table of payments (in EUR) for this task; TOML format:	[jacob] amount = 1000 submitted = 2024-02-26 paid = 2024-03-08

Description Jacob Lifshay 2023-04-20 02:17:33 BST

I looked and found some more instructions that I think need to change how they're XLEN-ified:

I put the changes in the change-xlenification-bug-1064 branch:
https://git.libre-soc.org/?p=openpower-isa.git;a=shortlog;h=refs/heads/change-xlenification-bug-1064

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=c19e4136b5ed830dbf511e53cdf05e53b64936e4

Comment 1 Jacob Lifshay 2023-04-20 02:20:08 BST

I found them by searching in openpower-isa/openpower/isa for:
(?<!OV|CA)(?<![0-9])(7|8|15|16|31|32|63|64)(?![0-9])

basically searching for all powers of 2 and one less from 7 to 64 but ignoring OV32/CA32

Comment 2 Luke Kenneth Casson Leighton 2023-04-20 04:23:54 BST

(In reply to Jacob Lifshay from comment #0)
> I looked and found some more instructions that I think need to change how
> they're XLEN-ified:

yep doesn't surprise me.

btw there's no "see also" bugreports - i only encountered a couple
months old by accident on a keyword search.  please please for goodness
sake do the search straight away on creating a bug and add "see also"
and any other cross-referencing.

Comment 3 Jacob Lifshay 2023-04-21 04:29:21 BST

On branch change-xlenification-bug-1064
https://git.libre-soc.org/?p=openpower-isa.git;a=shortlog;h=b94b04d748729ea8cce3c61e527ced9d3835cff9

commit b94b04d748729ea8cce3c61e527ced9d3835cff9
Author: Jacob Lifshay <programmerjake@gmail.com>
Date:   Thu Apr 20 20:23:48 2023 -0700

    rename/convert/merge XLCASTU/XLCASTS to EXTZXL/EXTSXL

commit a4b43d331d625b4d22dd4b718072259cdfc6f4aa
Author: Jacob Lifshay <programmerjake@gmail.com>
Date:   Thu Apr 20 20:15:48 2023 -0700

    rewrite all uses of XLCASTU/XLCASTS

commit 2994f4876dacca8c81b79f3b45adbd46cc56b3cf
Author: Jacob Lifshay <programmerjake@gmail.com>
Date:   Thu Apr 20 20:13:57 2023 -0700

    add EXTZ since it's in PowerISA v3.1B (see lbz for an example)

Comment 4 Jacob Lifshay 2023-04-21 20:29:05 BST

merged to master. iirc that's all that needs to be changed since we use openpower-isa.git as our only pseudo-code reference for existing PowerISA insns, if there's something I forgot, feel free to re-open.