Bug 1139

Summary:	CI for ieee754fpu broken
Product:	Libre-SOC's first SoC	Reporter:	Jacob Lifshay <programmerjake>
Component:	Source Code	Assignee:	Jacob Lifshay <programmerjake>
Status:	RESOLVED FIXED
Severity:	normal	CC:	libre-soc-bugs, lkcl, programmerjake
Priority:	---
Version:	unspecified
Hardware:	PC
OS:	Linux
See Also:	https://bugs.libre-soc.org/show_bug.cgi?id=1135
NLnet milestone:	---	total budget (EUR) for completion of task and all subtasks:	0
budget (EUR) for this task, excluding subtasks' budget:	0	parent task for budget allocation:
child tasks for budget allocation:		The table of payments (in EUR) for this task; TOML format:

Description Jacob Lifshay 2023-08-12 02:22:42 BST

git clone "https://build.libre-soc.programmerjake.tk/build-archive.git" build-archive
cd build-archive
git checkout 746e9aec06ae2ab77be4a8d8a5cfe06a718fe9f2
less -R pipelines/563418/job-4541376-log.txt

Pipeline on GitLab: https://salsa.debian.org/Kazan-team/mirrors/ieee754fpu/-/pipelines/563418

Truncated Build Log:
------------------------------------------------------------

sfpy/posit.pyx:786:10: Variables cannot be declared with 'cpdef'. Use 'cdef' instead.

Error compiling Cython file:
------------------------------------------------------------
...
        self._c_quire = cposit.q32Clr()

    # conversion back to posit

    cpdef Posit32 to_posit(self):
        cpdef cposit.posit32_t f = cposit.q32_to_p32(self._c_quire)
              ^
------------------------------------------------------------

sfpy/posit.pyx:1097:14: Variables cannot be declared with 'cpdef'. Use 'cdef' instead.

Error compiling Cython file:
------------------------------------------------------------
...
cpdef Quire32 q32_qms(Quire32 acc, Posit32 a1, Posit32 a2):
    cdef cposit.quire32_t f = cposit.q32_fdp_sub(acc._c_quire, a1._c_posit, a2._c_posit)
    return Quire32.from_c_quire(f)

cpdef Posit32 q32_to_p32(Quire32 a1):
    cpdef cposit.posit32_t f = cposit.q32_to_p32(a1._c_quire)
          ^
------------------------------------------------------------

sfpy/posit.pyx:1171:10: Variables cannot be declared with 'cpdef'. Use 'cdef' instead.
make: *** [Makefile:23: cython] Error 1

Comment 1 Luke Kenneth Casson Leighton 2023-08-12 06:25:36 BST

(In reply to Jacob Lifshay from comment #0)

> ------------------------------------------------------------
> 
> sfpy/posit.pyx:786:10: Variables cannot be declared with 'cpdef'. Use 'cdef'
> instead.

forget posit. not in the least bit important.

use versions of all software from when this was working.
we do not have time or money to waste on "chasing latest and
greatest libraries".

reproducible builds, old and fixed explicit libraries is
a mandatory project requirement.

Comment 2 Jacob Lifshay 2023-08-13 05:21:30 BST

(In reply to Luke Kenneth Casson Leighton from comment #1)
> use versions of all software from when this was working.

yup, I just never got around to adding that to ieee754fpu CI

Comment 3 Luke Kenneth Casson Leighton 2023-08-13 09:58:44 BST

(In reply to Jacob Lifshay from comment #2)

> yup, I just never got around to adding that to ieee754fpu CI

cut posit entirely from Makefile, also always always always link
bugreport to at least something. otherwise it is impossible to find.

it is a mandatory project requirement that the graph from any bug
contain all other bugs (one "Group")

Comment 4 Jacob Lifshay 2023-08-13 14:29:15 BST

(In reply to Luke Kenneth Casson Leighton from comment #3)
> also always always always link
> bugreport to at least something. otherwise it is impossible to find.
> 
> it is a mandatory project requirement that the graph from any bug
> contain all other bugs (one "Group")

sorry, i forgot because I was mostly thinking this bug is a replacement for just emailing myself as a reminder,

Comment 5 Luke Kenneth Casson Leighton 2023-08-14 08:33:04 BST

(In reply to Jacob Lifshay from comment #4)

> sorry, i forgot because I was mostly thinking this bug is a replacement for
> just emailing myself as a reminder,

and if someone else finds the same problem and
reports the same bug? it wastes other people's
time, to think like that, doesn't it?

do make it an unconditional habit, as *other people*
when navigating are in no way going to do so by "keyword searches"
if they have absolutely no clue what to search for, are they?

Comment 6 Jacob Lifshay 2023-08-16 03:28:46 BST

CI now passes.

https://git.libre-soc.org/?p=ieee754fpu.git;a=shortlog;h=829dfbc53ba38ec17bc544cb0b862e73cee223db

commit 829dfbc53ba38ec17bc544cb0b862e73cee223db
Author: Jacob Lifshay <programmerjake@gmail.com>
Date:   Tue Aug 15 19:05:15 2023 -0700

    switch to exact version of cython

commit e4b4e335682c5bc3cb34ce968441e0acba199030
Author: Jacob Lifshay <programmerjake@gmail.com>
Date:   Tue Aug 15 18:56:51 2023 -0700

    fix CI

Comment 7 Jacob Lifshay 2023-08-16 03:29:59 BST

also reported bug upstream: https://github.com/billzorn/sfpy/issues/4