| Summary: | removing some f-strings and misleading log messages | ||
|---|---|---|---|
| Product: | Libre-SOC's first SoC | Reporter: | Jacob Lifshay <programmerjake> |
| Component: | Source Code | Assignee: | Jacob Lifshay <programmerjake> |
| Status: | IN_PROGRESS --- | ||
| Severity: | enhancement | CC: | libre-soc-bugs, lkcl, programmerjake |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.libre-soc.org/show_bug.cgi?id=1072 | ||
| NLnet milestone: | --- | total budget (EUR) for completion of task and all subtasks: | 0 |
| budget (EUR) for this task, excluding subtasks' budget: | 0 | parent task for budget allocation: | |
| child tasks for budget allocation: | The table of payments (in EUR) for this task; TOML format: | ||
| Bug Depends on: | 939, 589 | ||
| Bug Blocks: | |||
|
Description
Jacob Lifshay
2023-10-21 00:07:37 BST
one of the reasons for not adding every SPR is that some of them are aliases for high and low 32-bit halves. adding that is not necessary. the reason for not using PHP string formatting has been made clear multiple times systematically on multiple occasions. so many that it was set over two years ago as a hard requirement of the project's HDL_workflow development practices. there is now a massive technical debt thanks to ths hard requirement being blatantly disregarded by multiple contributors. 1540 log(f"write OV/OV32 OV={ov} OV32={ov32}",
1541 kind=LogKind.InstrInOuts)
1542 else:
1543 # TODO: if 32-bit mode, set ca to ca32
1544 self.spr['XER'][XER_bits['CA']] = ca
1545 self.spr['XER'][XER_bits['CA32']] = ca32
1546 log(f"write CA/CA32 CA={ca} CA32={ca32}",
1547 kind=LogKind.InstrInOuts)
253 line_bytes = mem_lines[line_index]
254 line_str = f"0x{line_addr:08X}:"
255 for col_chunk in range(0, line_size,
256 column_chunk_size):
257 line_str += " "
258 for i in range(column_chunk_size):
259 line_str += f" {line_bytes[col_chunk + i]:02X}"
260 line_str += " |"
261 for i in range(line_size):
262 if 0x20 <= line_bytes[i] <= 0x7E:
263 line_str += chr(line_bytes[i])
264 else:
265 line_str += "."
266 line_str += "|"
267 lines.append(line_str)
268 lines = "\n".join(lines)
269 log(f"\n{name}:\n{lines}\n", kind=kind)
270
343 if addr != expected:
344 exc = MemException("not sign extended",
345 f"address not sign extended: 0x{addr:X} "
346 f"expected 0x{expected:X}")
347 exc.dar = addr
348 raise exc
349 return page_idx
350
351 def __reduce_ex__(self, protocol):
352 raise PicklingError("MemMMap can't be deep-copied or pickled")
353
354 def __access_addr_range_err(self, start_addr, size, needed_flag):
355 assert needed_flag != _MMapPageFlags.W, \
356 f"can't write to address 0x{start_addr:X} size 0x{size:X}"
385 assert block is not None, \
386 f"can't read from address 0x{start_addr:X} size 0x{size:X}"
387 return (ctypes.c_ubyte * size).from_buffer(block, block_addr)
388
77 for first_old_fname in found:
78 found_str = " ".join(f"'{i}'" for i in found)
79 lines = [
80 f"found likely old generated file: {first_old_fname!r}",
81 f"new location: {first_fname!r}",
82 ("please remove the old generated files to avoid committing "
83 "them or add to:"),
84 ("openpower.decoder.pseudo.pywriter."
85 "OLD_GENERATED_FILES_EXCEPTIONS"),
86 "commands to remove all likely old generated files:",
87 f"(cd {isadir}; rm -v {found_str})",
88 ]
i'm setting this to lower priority, since cavatools needs to be finished first. (In reply to Jacob Lifshay from comment #7) > i'm setting this to lower priority, since cavatools needs to be finished > first. bug #939. and the crypto-primitives bug #589. |