| Summary: | FMIN/MAX needed | ||
|---|---|---|---|
| Product: | Libre-SOC's first SoC | Reporter: | Luke Kenneth Casson Leighton <lkcl> |
| Component: | ALU (including IEEE754 16/32/64-bit FPU) | Assignee: | Michael Nolan <mtnolan2640> |
| Status: | PAYMENTPENDING FIXED | ||
| Severity: | enhancement | CC: | libre-soc-bugs, mtnolan2640 |
| Priority: | --- | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| NLnet milestone: | NLnet.2019.02.012 | total budget (EUR) for completion of task and all subtasks: | 200 |
| budget (EUR) for this task, excluding subtasks' budget: | 200 | parent task for budget allocation: | 48 |
| child tasks for budget allocation: | The table of payments (in EUR) for this task; TOML format: |
mnolan={amount=200, submitted=2020-02-09, paid=2020-02-09}
|
|
| Bug Depends on: | |||
| Bug Blocks: | 48 | ||
|
Description
Luke Kenneth Casson Leighton
2019-08-07 10:01:24 BST
I'd like to give this one a go if that's alright. yeah go for it. here's the scala reference code: https://github.com/chipsalliance/rocket-chip/blob/master/src/main/scala/tile/FPU.scala#L530 michael i included an import os and os.path.split(__file__) so that the read of the .sby file is location-independent > michael i included an import os and os.path.split(__file__) so that the read of > the .sby file is location-independent
I saw that, I made a small change to fix it when running the proof from the proof directory.
I'm planning on refactoring the proof runner into a separate file in fpcommon/ as well.
(In reply to Michael Nolan from comment #4) > > michael i included an import os and os.path.split(__file__) so that the read of > the .sby file is location-independent > > I saw that, I made a small change to fix it when running the proof from the > proof directory. > > I'm planning on refactoring the proof runner into a separate file in > fpcommon/ as well. have a look at the nmigen/test/test_lib_fifo.py because i don't believe it's necessary to manually call sby from a subprocess: nmigen should take care of it. nmigen/test/utils.py - already done. > have a look at the nmigen/test/test_lib_fifo.py because i don't believe > it's necessary to manually call sby from a subprocess: nmigen should > take care of it. That's pretty nice. I was following this tutorial for nmigen's formal verification and it didn't have that: https://github.com/RobertBaruch/nmigen-tutorial/blob/master/8_formal_verification.md are we happy that this is done, now? unit test seems good. > are we happy that this is done, now? unit test seems good.
Yes, I think so. Should I submit an RFP?
do both of them at the same time, create a draft, send it to me for review. email me privately. |