Bug 284

Summary: TypeError Object is not an nMigen signal
Product: Libre-SOC's first SoC Reporter: Tobias Platen <libre-soc>
Component: Source CodeAssignee: Luke Kenneth Casson Leighton <lkcl>
Status: RESOLVED FIXED    
Severity: enhancement CC: libre-soc-bugs, programmerjake
Priority: ---    
Version: unspecified   
Hardware: Other   
OS: Linux   
NLnet milestone: --- total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0 parent task for budget allocation:
child tasks for budget allocation: The table of payments (in EUR) for this task; TOML format:

Description Tobias Platen 2020-04-14 09:26:14 BST
When running tests with the latest version of nmigen I get the following error:

Traceback (most recent call last):
  File "test_sim.py", line 98, in test_sub
    self.run_tst_program(program, [1, 2, 3, 4, 5])
  File "test_sim.py", line 102, in run_tst_program
    self.run_tst(prog, simulator)
  File "test_sim.py", line 49, in run_tst
    traces=pdecode2.ports()):
  File "/usr/local/lib/python3.7/dist-packages/nmigen-0.3.dev20+g0e40dc0-py3.7.egg/nmigen/back/pysim.py", line 1125, in write_vcd
    vcd_file=vcd_file, gtkw_file=gtkw_file, traces=traces)
  File "/usr/local/lib/python3.7/dist-packages/nmigen-0.3.dev20+g0e40dc0-py3.7.egg/nmigen/back/pysim.py", line 95, in __init__
    if trace not in signal_names:
  File "/usr/lib/python3.7/_collections_abc.py", line 666, in __contains__
    self[key]
  File "/usr/local/lib/python3.7/dist-packages/nmigen-0.3.dev20+g0e40dc0-py3.7.egg/nmigen/hdl/ast.py", line 1392, in __getitem__
    key = None if key is None else self._map_key(key)
  File "/usr/local/lib/python3.7/dist-packages/nmigen-0.3.dev20+g0e40dc0-py3.7.egg/nmigen/hdl/ast.py", line 1582, in __init__
    raise TypeError("Object {!r} is not an nMigen signal".format(signal))
TypeError: Object (rec <unnamed> rego rego_ok) is not an nMigen signal

I already fixed that kind of error and it reappeared after running git pull.
Comment 1 Jacob Lifshay 2020-04-14 09:38:04 BST
which nmigen remote are you using?
also, which repo is this? soc?

You could try looking through the recent builds on salsa to see if the error is reproduced there:
https://salsa.debian.org/Kazan-team/soc/pipelines
Comment 2 Tobias Platen 2020-04-14 12:09:41 BST
I am using the https://github.com/nmigen/nmigen repo,
but our documentation says https://github.com/m-labs/nmigen

I am using the soc repo and the Kazan-team pipeline has failed too.
https://salsa.debian.org/Kazan-team/soc/pipelines/125651/failures.

The error is a different one in this case:
ModuleNotFoundError (No module named 'alu_hier')
Comment 3 Luke Kenneth Casson Leighton 2020-04-14 12:37:40 BST
(In reply to Tobias Platen from comment #2)
> I am using the https://github.com/nmigen/nmigen repo,
> but our documentation says https://github.com/m-labs/nmigen

please do update the documentation - don't wait, just do it
(and send a message to the list saying that it's been done).

> I am using the soc repo and the Kazan-team pipeline has failed too.
> https://salsa.debian.org/Kazan-team/soc/pipelines/125651/failures.

when those messages are available in a resource controlled by us - not
by debian, not by the proprietary hosting company gitlab - and replicable
by anyone, without requiring a permanent internet connection - i'll take a
look at them.

(reminds me, we really must do something about making bugzilla available
offline)
 
> The error is a different one in this case:
> ModuleNotFoundError (No module named 'alu_hier')

i'm dealing with some augmentations and changes to the 6600 scoreboard,
which is a particularly complex area.
Comment 4 Tobias Platen 2020-04-15 17:57:51 BST
Now the documentation is fixed
Comment 5 Luke Kenneth Casson Leighton 2020-04-15 22:08:30 BST
(In reply to Tobias Platen from comment #4)
> Now the documentation is fixed

fantastic.  if anyone finds discrepancies do just sort them.