Bug 287

Summary: corrections to commit f17100d6c435aec47b17acb188272a7e9b3cf67d
Product: Libre-SOC's first SoC Reporter: Luke Kenneth Casson Leighton <lkcl>
Component: Source CodeAssignee: Tobias Platen <libre-soc>
Status: RESOLVED FIXED    
Severity: enhancement CC: libre-soc-bugs
Priority: ---    
Version: unspecified   
Hardware: PC   
OS: Linux   
NLnet milestone: --- total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0 parent task for budget allocation:
child tasks for budget allocation: The table of payments (in EUR) for this task; TOML format:

Description Luke Kenneth Casson Leighton 2020-04-17 17:41:17 BST 
* add suitable separate unit tests for both mul and carry.
  add them as *separate commits* with a message "unit test for sim multiply"
  and "unit tests for sim carry"

* remove the whitespace added around lines 140.  ensure that there is
  only one newline (not two)

* remove the redundant brackets in these two statements:

+        if(cry_out==1):
+            if(result > 0xFFFFFFFF):

* ensure that one space is between "if" and its "test"

   if cry_out == 1:
Comment 1 Luke Kenneth Casson Leighton 2020-04-18 10:17:06 BST 
tobias, see:
http://lists.libre-riscv.org/pipermail/libre-riscv-dev/2020-April/006019.html