Bug 497

Summary:	use of pia is not being properly maintained and now the unit tests don't work
Product:	Libre-SOC's first SoC	Reporter:	Luke Kenneth Casson Leighton <lkcl>
Component:	Source Code	Assignee:	Jacob Lifshay <programmerjake>
Status:	RESOLVED INVALID
Severity:	blocker	CC:	libre-soc-bugs
Priority:	Highest
Version:	unspecified
Hardware:	PC
OS:	Linux
NLnet milestone:	---	total budget (EUR) for completion of task and all subtasks:	0
budget (EUR) for this task, excluding subtasks' budget:	0	parent task for budget allocation:
child tasks for budget allocation:		The table of payments (in EUR) for this task; TOML format:
Bug Depends on:
Bug Blocks:	383

Description Luke Kenneth Casson Leighton 2020-09-22 10:15:50 BST

div pipe tests no longer function correctly - 2 days before a code-freeze
is needed - because changes to pia have been carried out without also
updating the code that uses it.

Comment 1 Jacob Lifshay 2020-09-22 10:28:53 BST

I did update soc.git to work when I finished the new version of pia

Comment 2 Jacob Lifshay 2020-09-22 10:34:26 BST

updated in:
https://git.libre-soc.org/?p=soc.git;a=commit;h=4b6bf62bc0de1eaab9fb3c0c67121722e722aa3b

on Thu, 3 Sep 2020 21:32:56 -0700

update to match refactored power-instruction-analyzer API

matches the api of power-instruction-analyzer commit e828d2acecc25a82d5c29b765163a10993547566

Comment 3 Jacob Lifshay 2020-09-22 10:42:28 BST

I'll check tomorrow morning, but I'm pretty sure it works fine and Luke somehow failed to update power-instruction-analyzer.

Am inclined to close as invalid, but will wait till I can thoroughly test it.

Comment 4 Luke Kenneth Casson Leighton 2020-09-22 11:04:39 BST

(In reply to Jacob Lifshay from comment #3)
> I'll check tomorrow morning, but I'm pretty sure it works fine and Luke
> somehow failed to update power-instruction-analyzer.
> 
> Am inclined to close as invalid, but will wait till I can thoroughly test it.

ok thanks.

Comment 5 Jacob Lifshay 2020-09-22 19:12:35 BST

Am currently running the tests, so far it appears to be working as expected.

Comment 6 Luke Kenneth Casson Leighton 2020-09-22 19:38:38 BST

yes i updated the simulator pseudocode for divwe etc and i think the div long test is the one most likely to catch errors.

i am not 100% sure we cover enough though.

thank you for checking.

Comment 7 Jacob Lifshay 2020-09-22 19:41:03 BST

(In reply to Jacob Lifshay from comment #5)
> Am currently running the tests, so far it appears to be working as expected.

All tests appear to work as expected, no errors caused by power-instruction-analyzer.

Comment 8 Jacob Lifshay 2020-09-22 19:45:08 BST

commit 0d233dbc5d08d7f6c98a68a1d4f0cb94157c97a1 (HEAD -> master, origin/master, origin/HEAD)
Author: Jacob Lifshay <programmerjake@gmail.com>
Date:   Tue Sep 22 11:42:49 2020 -0700

    Revert "disable pia in div tests"

    Bug #497 resolved as invalid

    This reverts commit 05b9baec72be4ef56de2ed56ec12cbf5f7f0eefe.