Bug 516

Summary: rldicl unit test failure
Product: Libre-SOC's first SoC Reporter: Luke Kenneth Casson Leighton <lkcl>
Component: Source CodeAssignee: Luke Kenneth Casson Leighton <lkcl>
Status: RESOLVED FIXED    
Severity: blocker CC: libre-soc-bugs
Priority: Highest    
Version: unspecified   
Hardware: PC   
OS: Linux   
NLnet milestone: --- total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0 parent task for budget allocation:
child tasks for budget allocation: The table of payments (in EUR) for this task; TOML format:
Bug Depends on:    
Bug Blocks: 383    

Description Luke Kenneth Casson Leighton 2020-10-07 16:14:57 BST
FAIL: run_all (__main__.TestRunner) [case_rlc]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "fu/shift_rot/test/test_pipe_caller.py", line 305, in process
    yield from self.execute(alu, instruction, pdecode2, test)
  File "fu/shift_rot/test/test_pipe_caller.py", line 276, in execute
    simulator, code)
  File "fu/shift_rot/test/test_pipe_caller.py", line 338, in check_alu_outputs
    ALUHelpers.check_int_o(self, res, sim_o, code)
  File "/home/lkcl/src/libresoc/soc/src/soc/fu/test/common.py", line 512, in check_int_o
    dut.assertEqual(expected, alu_out, msg)
AssertionError: 8228076519210809531 != 11432643702850322432 : rldic 3, 1, 52, 41
Comment 1 Luke Kenneth Casson Leighton 2020-10-07 18:29:36 BST
wheww, that's all this was

commit b6a41fb88c8ebe6dfa0f551d91143997d47910cb (HEAD -> master, origin/master)
Author: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date:   Wed Oct 7 18:28:53 2020 +0100

    missing invert_in field from shiftrot input record