| Summary: | bpermd XLEN update needs refinement | ||
|---|---|---|---|
| Product: | Libre-SOC's first SoC | Reporter: | Luke Kenneth Casson Leighton <lkcl> |
| Component: | Specification | Assignee: | Dmitry Selyutin <ghostmansd> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | libre-soc-isa |
| Priority: | --- | ||
| Version: | unspecified | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| NLnet milestone: | --- | total budget (EUR) for completion of task and all subtasks: | 0 |
| budget (EUR) for this task, excluding subtasks' budget: | 0 | parent task for budget allocation: | |
| child tasks for budget allocation: | The table of payments (in EUR) for this task; TOML format: | ||
| Bug Depends on: | |||
| Bug Blocks: | 671 | ||
|
Description
Luke Kenneth Casson Leighton
2021-08-30 14:27:42 BST
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=5fee1b0a044b78890c747d359f7bfed8c8c585dd @@ -468,11 +468,11 @@ Pseudo-code: perm <- [0] * 8 for i = 0 to 7 index <- (RS)[8*i:8*i+7] - if index <u 64 then + if index <u XLEN then perm[i] <- (RB)[index] else perm[i] <- 0 - RA <- [0]*56 || perm[0:7] + RA <- [0]*(XLEN-8) || perm[0:7] the for-loop for i = 0 to 7 needs adjusting otherwise it will overrun RS. for i = 0 to (XLEN/8-1) would probably do the trick. see https://bugs.libre-soc.org/show_bug.cgi?id=671#c26 (In reply to Luke Kenneth Casson Leighton from comment #1) > https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff; > h=5fee1b0a044b78890c747d359f7bfed8c8c585dd Nice catch, thank you! Pushed the fixup. https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=d37f57284c5649d7b420a43b89f2ee579efcca35 Should this one be closed? (In reply to dmitry.selyutin from comment #3) > Should this one be closed? once linked on your homepage, so it's not forgotten when it comes to RFPs, yes. (In reply to Luke Kenneth Casson Leighton from comment #4) > (In reply to dmitry.selyutin from comment #3) > once linked on your homepage, so it's not forgotten when it comes > to RFPs, yes. Done |