Bug 682

Summary: srad XLEN override fails unit tests
Product: Libre-SOC's first SoC Reporter: Luke Kenneth Casson Leighton <lkcl>
Component: Source CodeAssignee: Luke Kenneth Casson Leighton <lkcl>
Status: RESOLVED INVALID    
Severity: enhancement CC: libre-soc-bugs
Priority: ---    
Version: unspecified   
Hardware: PC   
OS: Linux   
NLnet milestone: --- total budget (EUR) for completion of task and all subtasks: 0
budget (EUR) for this task, excluding subtasks' budget: 0 parent task for budget allocation:
child tasks for budget allocation: The table of payments (in EUR) for this task; TOML format:
Bug Depends on:    
Bug Blocks: 671    

Description Luke Kenneth Casson Leighton 2021-09-01 20:36:42 BST
======================================================================
FAIL: run_all (__main__.ShiftRotTestRunner) [case_shift]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/lkcl/src/libresoc/soc/src/soc/fu/compunits/test/test_compunit.py", line 361, in process
    test)
  File "/home/lkcl/src/libresoc/soc/src/soc/fu/compunits/test/test_compunit.py", line 317, in execute
    code)
  File "fu/compunits/test/test_shiftrot_compunit.py", line 37, in check_cu_outputs
    self.assertEqual(expected, cu_out, code)
AssertionError: 39739355776 != 2046480857 : srad 3, 1, 2

even after fixing off-by-one error, still failing
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=48a90aed14741e38d97fa7b1ceb31cf028684db5

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=a88be70080d9d3eda3a5c80c7a9fead7a7393120
Comment 1 Luke Kenneth Casson Leighton 2021-09-03 17:50:25 BST
looks like a false alarm due to forgetting to run pywriter
after fixing a previous bug.  re-running test_issuer.py
to confirm.
Comment 2 Luke Kenneth Casson Leighton 2021-09-03 18:11:27 BST
yep my fault. all good.  test_issuer.py works fine.